Skip to content

Better ZHA device reconfiguration#49672

Merged
Adminiuga merged 3 commits intohome-assistant:devfrom
dmulcahey:dm/reconfigure-device-phase-2
Apr 27, 2021
Merged

Better ZHA device reconfiguration#49672
Adminiuga merged 3 commits intohome-assistant:devfrom
dmulcahey:dm/reconfigure-device-phase-2

Conversation

@dmulcahey
Copy link
Copy Markdown
Contributor

@dmulcahey dmulcahey commented Apr 25, 2021

Proposed change

This PR continues the work on the reconfiguration dialog for ZHA devices. The log relaying has been replaced by events that the UI uses to provide a more user friendly visual representation for the reconfiguration process.

reconfigure3.mov

RELATED UI PR home-assistant/frontend#8990

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @Adminiuga, mind taking a look at this pull request as its been labeled with an integration (zha) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@Adminiuga
Copy link
Copy Markdown
Contributor

Why the tests are failing 🤔

@dmulcahey
Copy link
Copy Markdown
Contributor Author

Dunno. I’ll look in the morning

@KapJI
Copy link
Copy Markdown
Member

KapJI commented Apr 26, 2021

Note that zha integration is excluded from type checking because it doesn't pass mypy checks:
https://github.com/home-assistant/core/blob/dev/script/hassfest/mypy_config.py#L256

Please consider fixing this (in another PR).

Copy link
Copy Markdown
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Adminiuga Adminiuga merged commit b91d2be into home-assistant:dev Apr 27, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 28, 2021
@dmulcahey dmulcahey deleted the dm/reconfigure-device-phase-2 branch November 11, 2022 21:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ZHA "Reconfigure Device" causing zigpy modules logs level to switch to debug until next core reboot

4 participants